Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Drag & Drop for Visual Editing #86

Merged
merged 5 commits into from
Dec 2, 2024
Merged

Add Drag & Drop for Visual Editing #86

merged 5 commits into from
Dec 2, 2024

Conversation

kenjonespizza
Copy link
Collaborator

@kenjonespizza kenjonespizza commented Nov 22, 2024 •
edited
Loading

Add Drag & Drop Visual editing following https://www.sanity.io/docs/enabling-drag-and-drop.

Todo, finish TypeScripting - Edit Done ✅

@kenjonespizza kenjonespizza requested a review from a team as a code owner November 22, 2024 20:17
@vercel Vercel
Copy link

vercel bot commented Nov 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
template-nextjs-clean ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 4:17pm

@socket-security Socket Security
Copy link

socket-security bot commented Nov 27, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@sanity/[email protected] Transitive: environment +26 5.53 MB armandocerna, ash, atombender, ...61 more
npm/@types/[email protected] None +1 2.3 MB types
npm/[email protected] environment Transitive: eval, network +72 37.3 MB sanity-io
npm/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +811 634 MB ash
npm/[email protected] Transitive: environment, filesystem, unsafe +100 84.9 MB armandocerna, ash, atombender, ...61 more

🚮 Removed packages: npm/@sanity/[email protected], npm/@types/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

rdunk
rdunk requested changes Dec 2, 2024
View reviewed changes
Copy link
Member

@rdunk rdunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I think this looks good, just one suggestion around createDataAttribute

nextjs-app/sanity/lib/utils.ts Outdated Show resolved Hide resolved
nextjs-app/app/components/PageBuilder.tsx Outdated Show resolved Hide resolved
@kenjonespizza kenjonespizza merged commit 649ca7a into main Dec 2, 2024
5 of 8 checks passed
@kenjonespizza kenjonespizza deleted the feature/visual-editing-dnd branch December 2, 2024 16:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rdunk rdunk rdunk requested changes

@georgedoescode georgedoescode Awaiting requested review from georgedoescode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjonespizza @rdunk