[pull] master from spreedly:master #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Bump version to 1.13.0 Closes #88
A compatibility introduced to later versions of Brod prevented Kaffe from working if endpoints were specified as atoms. After reporting the issue to the Brod maintainers, they indicated that Brod wants charlists (Erlang strings) for these values. This commit converts binaries and atoms to charlists, so both should work with older and newer versions of Brod. Therefore, the Brod dependency is now specified as `~> 3.0`. Also fixed some small README issues. Fixes #75
Version is now 1.15.0. Closes #94
Closes #97
ERO-298
* Now requires Elixir ~> 1.7 All tests pass: mix test 4 doctests, 47 tests, 0 failures, 1 excluded mix test --only e2e 4 doctests, 47 tests, 0 failures, 50 excluded ERO-298
This commit addresses issue #93 which allows the Group Manager to retry connecting group members to topics when Kafka is down. The amount of retries and the retry interval are configurable with Kaffe.Config.Consumer. Default is 3 retries every 10 seconds. When retry options are pruned completely, Group Manager will no longer be able to recover. This behaviour is expected, because it is most likely that if reconnections are not possible in a set amount of time, intervention is required. Retrying indefinitely does not make sense.
All tests pass. mix test 4 doctests, 47 tests, 0 failures, 1 excluded mix test --only e2e 4 doctests, 47 tests, 0 failures, 50 excluded
mix test 4 doctests, 47 tests, 0 failures, 1 excluded mix test --only e2e 4 doctests, 47 tests, 0 failures, 50 excluded
warning: :crypto.rand_uniform/2 is deprecated. Use rand:uniform/1 instead lib/kaffe/partition_selector.ex:28: Kaffe.PartitionSelector.random/1 https://www.erlang.org/doc/man/crypto.html#rand_uniform-2 https://www.erlang.org/doc/man/rand.html#uniform-1
* Misc doc changes Besides other documentation changes, this commit ensures the generated HTML doc for HexDocs.pm will become the source of truth for this Elixir library and leverage on latest features of ExDoc. Co-authored-by: britth <[email protected]>
mix test 4 doctests, 47 tests, 0 failures, 1 excluded mix test --only e2e 4 doctests, 47 tests, 0 failures, 50 excluded
mix test 4 doctests, 47 tests, 0 failures, 1 excluded mix test --only e2e 4 doctests, 47 tests, 0 failures, 50 excluded
Upgrades Elixir dependency to 1.12 mix test 4 doctests, 47 tests, 0 failures, 1 excluded mix test --only e2e 4 doctests, 47 tests, 0 failures, 50 excluded
In case the kafka cluster is temporarily unavailable, when subscribe_to_topics retries are exhausted, it simply exits the function without crashing, and when kafka cluster is back, it won't subscribe to topics, and the consumer gets stuck. With this change, it will crash after retries are exhausted and topic subscription didn't complete successfully
mix test 4 doctests, 47 tests, 0 failures, 1 excluded mix test --only e2e 4 doctests, 47 tests, 0 failures, 50 excluded
Fix Logger.warn deprecation
Upgrades the Elixir version to 1.14 mix test 4 doctests, 47 tests, 0 failures, 1 excluded mix test --only e2e 4 doctests, 47 tests, 0 failures, 50 excluded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )