sap_hypervisor_node_preconfigure: replace use of oc with kubernetes.core.k8s

[geetikakay]

roles/sap_hypervisor_node_preconfigure/tasks/platform/redhat_ocp_virt/main.yml

• Check and fail is added if any node is not available

roles/sap_hypervisor_node_preconfigure/tasks/platform/redhat_ocp_virt/configure-worker-node.yml

• Check and fail is added if any node is not available
• Change oc label node to use kubernetes.core

[sean-freeman]

@geetikakay Agree with oc command removal, this should be agonstic for KubeVirt provisioning.

I do not have access to a KubeVirt instance, 60mins seems sensible because hardware can vary and take a long time for provisioning of large VMs (e.g. 6TiB DRAM) for SAP HANA.

[sean-freeman]

@newkit Can you please review and test this PR ?

At the same time, can you please confirm that the latest kubevirt.core.kubevirt_vm Ansible Module has solved the int parsing issues and does not require workaround usage of ANSIBLE_JINJA2_NATIVE env var?

[geetikakay]

@geetikakay Agree with oc command removal, this should be agonstic for KubeVirt provisioning.

I do not have access to a KubeVirt instance, 60mins seems sensible because hardware can vary and take a long time for provisioning of large VMs (e.g. 6TiB DRAM) for SAP HANA.

@sean-freeman Done, I have increased the retries.

[newkit]

Finished review

[geetikakay]

Finished review

@newkit Thanks , I did requested changes. Please have a look.

[newkit]

@newkit Can you please review and test this PR ?

Reviewed and tested

At the same time, can you please confirm that the latest kubevirt.core.kubevirt_vm Ansible Module has solved the int parsing issues and does not require workaround usage of ANSIBLE_JINJA2_NATIVE env var?

We are still trying to fix the int issue but it's a tough nut. So for now, the ANSIBLE_JINJA2_NATIVE=true workaround is still needed when running the redhat_ocp_virt flavor of the sap_vm_provision role.

[newkit]

This PR became obsolete since there is a better version of this fix in this PR.