Skip to content

Commit

Permalink
sap_general_preconfigure: skip var-naming[no-role-prefix]
Browse files Browse the repository at this point in the history
... for the three variables sap_hostname, sap_domain, sap_ip.

Those are used in many places in the role and the effort for changing
and testing the code is too high given that we plan to replace this
part of the role by the new role sap_maintain_etc_hosts.

Relates to #589.

Signed-off-by: Bernd Finger <[email protected]>
  • Loading branch information
berndfinger committed Jan 12, 2024
1 parent 576e6db commit dccd5a9
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions roles/sap_general_preconfigure/defaults/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -145,13 +145,16 @@ sap_general_preconfigure_kernel_parameters: "{{ __sap_general_preconfigure_kerne
sap_general_preconfigure_max_hostname_length: '13'
# The maximum length of the hostname. See SAP note 611361.

sap_hostname: "{{ ansible_hostname }}"
# Reason for noqa: A separate role is planned to replace the code which uses this variable.
sap_hostname: "{{ ansible_hostname }}" # noqa var-naming[no-role-prefix]
# The hostname to be used for updating or checking `/etc/hosts` entries.

sap_domain: "{{ ansible_domain }}"
# Reason for noqa: A separate role is planned to replace the code which uses this variable.
sap_domain: "{{ ansible_domain }}" # noqa var-naming[no-role-prefix]
# The DNS domain name to be used for updating or checking `/etc/hosts` entries.

sap_ip: "{{ ansible_default_ipv4.address }}"
# Reason for noqa: A separate role is planned to replace the code which uses this variable.
sap_ip: "{{ ansible_default_ipv4.address }}" # noqa var-naming[no-role-prefix]
# The IPV4 address to be used for updating or checking `/etc/hosts` entries.

# sap_general_preconfigure_db_group_name: (not defined by default)
Expand Down

0 comments on commit dccd5a9

Please sign in to comment.