Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap_maintain_etc_hosts: Wrong assert message #662

Closed
berndfinger opened this issue Feb 22, 2024 · 1 comment
Closed

sap_maintain_etc_hosts: Wrong assert message #662

berndfinger opened this issue Feb 22, 2024 · 1 comment
Assignees

Comments

@berndfinger
Copy link
Member

In

- name: Verify that variable domain_name is set
, the following message is displayed:

msg: "Variable 'domain_name' is undefined or empty. Please define it your host list"

However, the assertion checks for the variable named __sap_maintain_etc_hosts_domain. This is set in:

__sap_maintain_etc_hosts_domain: "{{ thishost.node_domain | default(sap_domain) | default(ansible_domain) }}"

to be one of:

  • thishost.node_domain
  • sap_domain
  • ansible_domain

but not domain_name.

An updated message should take into account the case of this role being called from another role, so maybe it needs to be more generic.

@berndfinger berndfinger self-assigned this Feb 22, 2024
berndfinger added a commit to berndfinger/community.sap_install that referenced this issue Feb 29, 2024
berndfinger added a commit to berndfinger/community.sap_install that referenced this issue Mar 4, 2024
@berndfinger
Copy link
Member Author

Solved by #668.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant