sap_general_preconfigure: Use the role sap_maintain_etc_hosts - RHEL systems #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves issue sap-linuxlab#658. Signed-off-by: Bernd Finger <[email protected]>
Avoids the violation of the 'var-naming[no-role-prefix]' ansible-lint rule. Relates to sap-linuxlab#658. Signed-off-by: Bernd Finger <[email protected]>
|
The following issue needs to be fixed soon after: #662 |
rainerleber
approved these changes
Feb 29, 2024
berndfinger
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to use a central role for all
/etc/hostsrelated manipulation (it is part of this collection already), so let's start withsap_general_preconfigure.At the same time, we can use new role variables which include the role prefix, replacing the previous "global" variables
sap_ip,sap_hostname, andsap_domainindefaults/main.yml(while still being compatible).I expect merge conflicts with #653 but it should not be too difficult to solve them, just annoying.