Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap_swpm: prepare_software changes ownership of files every time it runs #663

Closed
rnozaki opened this issue Feb 22, 2024 · 3 comments
Closed
Assignees

Comments

@rnozaki
Copy link
Contributor

rnozaki commented Feb 22, 2024

In the task prepare_software.yml there are 3 subtasks that will run to change the ownership of the SAP media directory and files, every time it runs.

This adds extra time on the execution (in one customer the media is from NFS, so it takes 15+ minutes more to run).

When running the automation multiple times on the same servers, or also on different servers, it gets to a point where we know that ownership was already set.

Can we make these subtasks optional? So if the user knows that the ownership was already validated/adjusted, they can run the automation with a flag that will prevent the execution of the redundant ownership change.

@berndfinger berndfinger self-assigned this Feb 22, 2024
@berndfinger
Copy link
Member

@rnozaki I agree, this behavior needs to be changed.
FYI - somehow similar issue but for role sap_hana_install: #199

@rnozaki
Copy link
Contributor Author

rnozaki commented Feb 27, 2024

OK, with the PR that I sent, the default behavior would not be changed.

So if someone knows for sure that they do not need to redo the ownership change (after having done it initially), then they can intentionally set the flag to false to avoid the redundant processing.

berndfinger added a commit to berndfinger/community.sap_install that referenced this issue Feb 28, 2024
Relates to sap-linuxlab#663.

Signed-off-by: Bernd Finger <[email protected]>
berndfinger added a commit to berndfinger/community.sap_install that referenced this issue Feb 29, 2024
@berndfinger
Copy link
Member

Solved in #665.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants