-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sap_swpm: optionally skip setting file permissions #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit supports optionally skipping setting permission and ownership of SAP installation files. It also introduces new role parameters for setting the mode, owner, and group of the software directory, the directory for SAPCAR, and the directory for SWPM, as well as the files within. Signed-off-by: Bernd Finger <[email protected]>
Relates to sap-linuxlab#663. Signed-off-by: Bernd Finger <[email protected]>
berndfinger
requested review from
sean-freeman,
Wabri,
rainerleber and
ja9fuchs
February 28, 2024 22:15
Relates to sap-linuxlab#663. Signed-off-by: Bernd Finger <[email protected]>
rhmk
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Wabri Do you want to have a look and comment/approve this PR? |
Yes, I'll do it! |
Wabri
requested changes
Mar 4, 2024
Signed-off-by: Bernd Finger <[email protected]>
... when there is no pipe. Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Wabri
approved these changes
Mar 5, 2024
Some background information on the proper permissions:
|
Also add the source for the permission and ownership information to defaults/main.yml. Signed-off-by: Bernd Finger <[email protected]>
ja9fuchs
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This was referenced Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports optionally skipping setting permission and ownership of SAP installation files. It also introduces new role parameters for setting the mode, owner, and group of the software directory, the directory for SAPCAR, and the directory for SWPM, as well as the files within.
Solves issue #663.