Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap_swpm: optionally skip setting file permissions #665

Merged
merged 7 commits into from
Mar 8, 2024

Conversation

berndfinger
Copy link
Member

This PR supports optionally skipping setting permission and ownership of SAP installation files. It also introduces new role parameters for setting the mode, owner, and group of the software directory, the directory for SAPCAR, and the directory for SWPM, as well as the files within.

Solves issue #663.

This commit supports optionally skipping setting permission and ownership
of SAP installation files. It also introduces new role parameters for
setting the mode, owner, and group of the software directory, the
directory for SAPCAR, and the directory for SWPM, as well as the files
within.

Signed-off-by: Bernd Finger <[email protected]>
Relates to sap-linuxlab#663.

Signed-off-by: Bernd Finger <[email protected]>
Copy link
Member

@rhmk rhmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@berndfinger
Copy link
Member Author

@Wabri Do you want to have a look and comment/approve this PR?

@Wabri
Copy link
Member

Wabri commented Mar 4, 2024

Yes, I'll do it!

@berndfinger berndfinger removed the request for review from sean-freeman March 4, 2024 19:41
@berndfinger
Copy link
Member Author

Some background information on the proper permissions:

  • Downloading and Extracting the Software Provisioning Manager 2.0 Archive in the Installation of SAP ABAP Systems on UNIX : SAP HANA 2.0 Database - Using Software Provisioning Manager 2.0 guide says about the download directory that it must have at least the permission 755.
  • It also mentions that all users must have read permissions for the directory where SWPM is to be extracted.
  • The same document mentions that the downloaded files must be extracted with the command sapcar -xvf.
  • And in the section Downloading the SAP HANA Database Software, it mentions that each installation media must be extracted to a separate folder and that it must not be in the same folder in which SWPM had been extracted. The same applies to the Database Installation Export and Language Software.
  • I found no mention of the required permissions for the SAR files so the permissions after the files have been downloaded with a user with umask 022 (resulting in the permission 0644) should be OK. This umask is mentioned in the same SWPM document, in chapter Installation->Prerequisites for Running Software Provisioning Manager. Unless someone finds another source, let's assume this umask setting is also to be used while downloading the SAP software.

Also add the source for the permission and ownership information to
defaults/main.yml.

Signed-off-by: Bernd Finger <[email protected]>
Copy link
Contributor

@ja9fuchs ja9fuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@berndfinger berndfinger removed the request for review from rainerleber March 8, 2024 14:04
@berndfinger berndfinger merged commit 992eacc into sap-linuxlab:dev Mar 8, 2024
4 checks passed
@berndfinger berndfinger deleted the issue-663 branch March 8, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants