sap_general_preconfigure - Checking for english locales, issue 907 #914
Conversation
…pdate Automation: number outdated packages in requirements-workflow.txt
Merge pull request sap-linuxlab#908 from sap-linuxlab/dev
…g and setting Fixes issue sap-linuxlab#907. Signed-off-by: Bernd Finger <[email protected]>
| success_msg: "PASS: An English locale is installed." | ||
|
|
||
| - name: Get the current default locale | ||
| ansible.builtin.command: awk '/^LANG=/&&/en_/{print}' /etc/locale.conf |
There was a problem hiding this comment.
this does not take into account that C.UTF-8 is also english
There was a problem hiding this comment.
You are right. Although C is English it is not sufficient for HANA2 SPS08. The en_* locales have to be installed.
A test run showed that having the system locale C while having en_* installed was sufficient.
I am not sure how we can deal with it. For now I suggest accepting C and en_* locales, as long as en_* is installed. IIRC SAP recommends en_US.UTF-8, so if some body has a proof for that and put here or to the issue would be great. Then we could at least print a warning.
There was a problem hiding this comment.
@rhmk I just installed HANA SPS08 (rev 81) on RHEL 9.4 using:
-
control node:
LANGset toen_US.UTF-8in the shell which called theansible-playbookcommand
-
managed node:
LANG="C.UTF-8"in /etc/locale.conf- package
glibc-langpack-enbeing installed but not packagelangpacks-en. An attempt to remove the packageglibc-langpack-enfailed due to a dependency on the packagegrub2-tools-minimal.
There was a problem hiding this comment.
suggested new awk statement:
awk '/^LANG=/&&(/C.UTF-8/||/en_/){print}' /etc/locale.conf
berndfinger
changed the title
| success_msg: "PASS: An English locale is installed." | ||
|
|
||
| - name: Get the current default locale | ||
| ansible.builtin.command: awk '/^LANG=/&&/en_/{print}' /etc/locale.conf |
There was a problem hiding this comment.
suggested new awk statement:
awk '/^LANG=/&&(/C.UTF-8/||/en_/){print}' /etc/locale.conf
There was a problem hiding this comment.
Change made and also fixed an issue with the variable check to set the locale
berndfinger
changed the title
| description: | ||
| - Use this variable to specify the default system locale. | ||
| example: | ||
| sap_general_preconfigure_db_group_name: 'en_US.UTF-8' |
There was a problem hiding this comment.
I am guessing you mean:
sap_general_preconfigure_default_locale: 'en_US.UTF-8' -- or C.UTF-8 depending what you think should be the "default" recommendation :)
There was a problem hiding this comment.
Thanks @Klaas- fixed this one, in addition @berndfinger and I found a bug in the algorithm so that this was variable was never used in certain circumstances (non-English locale set as default would always stop although variable was set)
This variable above is just an example, per default nothing is changed (variable empty in defaults/main.yml)
There was a problem hiding this comment.
I also removed the code from being executed on SLES because the reviewers are not available for the next weeks -- We may need to open another PR to enable this on SLES
| fail_msg: "FAIL: No English locale is installed. Please install an English locale!" | ||
| success_msg: "PASS: An English locale is installed." | ||
|
|
||
| - name: Configure English locale |
There was a problem hiding this comment.
I tested and now suggest to use the following code (including the comments to explain the logic a bit):
# We are setting a new locale from sap_general_preconfigure_default_locale if:
# - the new locale starts with "en_" or if it is "C.UTF-8" AND
# - the new locale (replacing "UTF-8" by "utf8" if necessary) is part of the installed locales
- name: Configure English locale
when:
- sap_general_preconfigure_default_locale is defined
- sap_general_preconfigure_default_locale | length > 0
- sap_general_preconfigure_default_locale.startswith('en_') or sap_general_preconfigure_default_locale == 'C.UTF-8'
- __sap_general_preconfigure_locales_installed.stdout_lines | select('match', sap_general_preconfigure_default_locale | regex_replace('UTF-8', 'utf8')) | join('') | trim | length > 0
It allows for setting an English locale using either the UTF-8 or utf8 notation (the output of locale -a contains only utf8 on RHEL 8 and RHEL 9) and also avoids setting an unsupported locale.
If there is an SAP supported OS which has UTF-8 in the output of locale -a, we could of course add the regex_replace filter also after __sap_general_preconfigure_locales_installed.stdout_lines.
This pull request checks that English locales are installed and set as the default. Additionally, a new variable allows for the enforcement of a specific English locale. This pull request is compatible with RHEL and SLES.