sap_general_preconfigure - Checking for english locales, issue 907 #914
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| --- | ||
| - name: Configure - Display SAP note number 2369910 and its version | ||
| ansible.builtin.debug: | ||
| msg: "SAP note {{ (__sap_general_preconfigure_sapnotes_versions | selectattr('number', 'match', '^2369910$') | first).number }} | ||
| (version {{ (__sap_general_preconfigure_sapnotes_versions | selectattr('number', 'match', '^2369910$') | first).version }}): SAP Software on Linux: General Information" | ||
| tags: | ||
| - always | ||
|
|
||
| - name: Check locales | ||
| when: sap_general_preconfigure_config_all | d(true) or sap_general_preconfigure_2369910 | d(false) | ||
| tags: | ||
| - sap_general_preconfigure_2369910 | ||
| - sap_general_preconfigure_configure_locale | ||
| block: | ||
| - name: Get list of installed locales | ||
| ansible.builtin.command: locale -a | ||
| changed_when: false | ||
| register: __sap_general_preconfigure_locales_installed | ||
|
|
||
| - name: Assert that an English locale is installed | ||
| ansible.builtin.assert: | ||
| that: __sap_general_preconfigure_locales_installed.stdout_lines | select('match', '^en_') | list | length > 0 | ||
|
There was a problem hiding this comment. Maybe this one is better, as it looks for ' en_[A-Z]*' AND Unicode: There was a problem hiding this comment. Update: As we only have to take into account operating systems on which the command So we can remove the tasks |
||
| fail_msg: "FAIL: No English locale is installed. Please install an English locale!" | ||
| success_msg: "PASS: An English locale is installed." | ||
|
|
||
| - name: Get the current default locale | ||
| ansible.builtin.command: awk '/^LANG=/&&/en_/{print}' /etc/locale.conf | ||
|
There was a problem hiding this comment. this does not take into account that C.UTF-8 is also english There was a problem hiding this comment. You are right. Although C is English it is not sufficient for HANA2 SPS08. The en_* locales have to be installed. There was a problem hiding this comment. @rhmk I just installed HANA SPS08 (rev 81) on RHEL 9.4 using:
There was a problem hiding this comment. suggested new |
||
| changed_when: false | ||
| register: __sap_general_preconfigure_current_default_locale | ||
|
|
||
| - name: Assert that an English locale is the default | ||
| ansible.builtin.assert: | ||
| that: __sap_general_preconfigure_current_default_locale.stdout_lines | length > 0 | ||
| fail_msg: "FAIL: English is not set as the default locale. Please define an English default locale with the 'sap_general_preconfigure_default_locale' variable!" | ||
| success_msg: "PASS: An English default locale is set." | ||
|
|
||
| - name: Assert that the role variable sap_general_preconfigure_default_locale starts with 'en_' | ||
| ansible.builtin.assert: | ||
| that: sap_general_preconfigure_default_locale.startswith('en_') | ||
| fail_msg: "FAIL: No English locale is defined in variable 'sap_general_preconfigure_default_locale'!" | ||
| success_msg: "PASS: The English default locale is valid" | ||
|
|
||
| - name: Configure English locale | ||
|
There was a problem hiding this comment. I tested and now suggest to use the following code (including the comments to explain the logic a bit): It allows for setting an English locale using either the If there is an SAP supported OS which has There was a problem hiding this comment. Update: With |
||
| ansible.builtin.lineinfile: | ||
| path: /etc/locale.conf | ||
| regexp: ^LANG= | ||
| line: "LANG=\"{{ sap_general_preconfigure_default_locale }}\"" | ||
| state: present | ||
| create: true | ||
| owner: root | ||
| group: root | ||
| mode: '0644' | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| --- | ||
| - name: Assert - Display SAP note number 2369910 and its version | ||
| ansible.builtin.debug: | ||
| msg: "SAP note {{ (__sap_general_preconfigure_sapnotes_versions | selectattr('number', 'match', '^2369910$') | first).number }} | ||
| (version {{ (__sap_general_preconfigure_sapnotes_versions | selectattr('number', 'match', '^2369910$') | first).version }}): SAP Software on Linux: General Information" | ||
| tags: | ||
| - always | ||
|
|
||
| ## STEP 3.1 -- System Language | ||
| - name: Step 3.1 - Check if English Language is installed | ||
| tags: | ||
| - sap_general_preconfigure_2369910 | ||
| - sap_general_preconfigure_2369910_03 | ||
| block: | ||
| - name: Get list of installed locales | ||
| ansible.builtin.command: locale -a | ||
| changed_when: false | ||
| register: __sap_general_preconfigure_locales_installed | ||
|
|
||
| - name: Assert that an English locale is installed | ||
| ansible.builtin.assert: | ||
| that: __sap_general_preconfigure_locales_installed.stdout_lines | select('match', '^en_') | list | length > 0 | ||
| fail_msg: "FAIL: No English locale is installed. Please install an English locale!" | ||
| success_msg: "PASS: An English locale is installed." | ||
|
|
||
| - name: Get the current default locale | ||
| ansible.builtin.command: awk '/^LANG=/&&/en_/{print}' /etc/locale.conf | ||
|
There was a problem hiding this comment. suggested new There was a problem hiding this comment. Change made and also fixed an issue with the variable check to set the locale |
||
| changed_when: false | ||
| register: __sap_general_preconfigure_current_default_locale | ||
|
|
||
| - name: Assert that an English locale is the default | ||
| ansible.builtin.assert: | ||
| that: __sap_general_preconfigure_current_default_locale.stdout_lines | length > 0 | ||
| fail_msg: "FAIL: English is not set as the default locale. Please define an English default locale with the 'sap_general_preconfigure_default_locale' variable!" | ||
| success_msg: "PASS: An English default locale is set." | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am guessing you mean:
sap_general_preconfigure_default_locale: 'en_US.UTF-8' -- or C.UTF-8 depending what you think should be the "default" recommendation :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Klaas- fixed this one, in addition @berndfinger and I found a bug in the algorithm so that this was variable was never used in certain circumstances (non-English locale set as default would always stop although variable was set)
This variable above is just an example, per default nothing is changed (variable empty in defaults/main.yml)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also removed the code from being executed on SLES because the reviewers are not available for the next weeks -- We may need to open another PR to enable this on SLES