Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap_ha_pacemaker_cluster: fixes to the VIP address parameters #458

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

ja9fuchs
Copy link
Contributor

  • strip the (optional) /xx cidr suffix from the IP address parameters
  • IP address parameters combined for configuration must correspond to the individual host's host type - this is needed to support defining e.g. HANA and NetWeaver IP parameters in the same config file, but avoid VIP resources to be configured in the wrong cluster

Copy link
Member

@sean-freeman sean-freeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the purpose behind these commits. I will need to test separately, but these are relatively benign alterations that improve long-term usability. Merge approved

@ja9fuchs ja9fuchs merged commit 88d3868 into sap-linuxlab:dev Sep 19, 2023
1 check passed
@ja9fuchs ja9fuchs deleted the ha-vip-fix branch September 21, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants