sap_ha_pacemaker_cluster: enhanced pre-checks and improved variable handling #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- sorted and updated defaults - sorted and updated argument specifications in sync with the defaults - adjusted 'ha_cluster' LSR parameter import and construction flow - new: all parameters are transformed into 'ha_cluster' native variables at play level - new: the 'ha_cluster' role include now relies on the new native variables, no more static list of vars
- added pre-flight checks for instance numbers - removed default required/type entries from argument_specifications - regenerated README - added prefix to internal vars and pre-defined them in vars/main.yml - simplified configuration output file structure and changed to 'ha_cluster' vars - fixed: the __ha_cluster_repos LSR variable has a __ prefix
sean-freeman
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new: pre-flight checks for instance numbers
new: all parameters are transformed into 'ha_cluster' native variables at play level
new: the 'ha_cluster' role include now relies on the defined native variables, no more static list of vars in the include task
simplification: removed required/type entries from argument_specifications that are default anyway
simplification: changed the output vars to display the used 'ha_cluster' vars in the optional configuration output file
house-keeping: added prefix to internal vars and pre-defined them in vars/main.yml
house-keeping: default parameter re-sorting into categories and applied the same sort order to the argument_specifications file