collection: merge dev to main for release 1.3.2 #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
while still using the previous file type detection method. The mechanism is as follows: If the variable 'sap_install_media_detect_target_directory' is definied and if this directory is writable, then the variable sap_install_media_detect_source is set to 'remote_dir', and this directory is used for copying and extracting files and also for moving the files as the last step. In all cases, as the first step, we create the required destination directories on the local, writable file system. Then we are creating a list of files for the product by checking the source directory. In case of remote_dir, we are then copying the identified files to the local directory. All remaining steps (extracting, moving and populating the final list of files) are done on the local directory.
The new method uses a tool named sapfile to examine the SAP and UNIX file types and populate a dictionary. Each file is stored with directory, file name, SAP file type, and archive file type. Using this method, the SAP file types have to be determined only once. The files are then copied to local storage (in case the software is located on a remote NFS file system), extracted and moved properly according to their entries in the dictionary. As the last step, the variables for SWPM are set using the entries for SAP file type in the dictionary, as these are identical to the subdirectory names.
With the new code now using the file/file type dictionary, handling the various file types in separate detect_...yml files is no longer necessary.
Also implement more tags and describe them in the README.md file No longer support sap_install_media_detect_skip_extraction_if_target_dir_exists because this behavior can be in part achieved by skipping tag sap_install_media_detect_organize_files.
With identical variables in `find_files_after_extraction.yml`, some of
them can be overwritten as follows:
"detect_directory_export_extracted": {
"changed": false,
"skip_reason": "Conditional result was False",
"skipped": true
}
These variables have to have different names so that the assignment of
final variables in `set_global_vars.yml` is done correctly.
This error did not happen with the previous version because each
detection was done in a separately included file.
The files without endings can now be renamed in the source directory even in case of remote_dir, if the source directory is writable. If the files without endings are located on a source directory which is not writable, the role will fail and explain the reason for the failure.
…car in sapfile utility
…sing vars for swpm
…nto issue-385-new-detection-method
…nto issue-385-new-detection-method
…te target directory
…dirs; fail early if files are missing
…files after extraction
…n service is absent
…_swpm_download_basket'
…related variables
sap_install_media_detect: Make the role (nearly) idempotent
sap_install_media_detect: Also recognize MP Stack XML files and correctly handle VCH AFL files
sap_ha_pacemaker_cluster: variable and file name adjustments
fix for sles and mp stack xml
- using `WaitforStarted` to allow instances to finish starting up - type change: `sap_ha_pacemaker_cluster_aws_vip_update_rt` must be a string, not a list - improved and aligned search conditionals
…ce_number to sap_ha_pacemaker_cluster_hana_instance_nr
sap_hana_install: Solve issue #484
fix remaining issues of #484
sap_ha_pacemaker_cluster: improved ASCS/ERS check logic
sap_ha_pacemaker_cluster: fix: pause before HACheckConfig is run
collection: prepare for v1.3.2
|
Thoroughly tested, alterations to vars noted in sap_install_media_detect and sap_ha* Ansible Role docs. Approved for merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.