Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collection: Enforce minimum ansible version 2.12 #533

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

berndfinger
Copy link
Member

Solves issue #507.

Note: We are using version 2.12 and not 2.14 to extend the range of possible control nodes to older releases (e.g. RHEL 8.6).

@sean-freeman sean-freeman self-requested a review November 24, 2023 11:25
Copy link
Member

@sean-freeman sean-freeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with move to Ansible Core 2.12 as minimum for executing (from controller host, e.g. laptop or AWX) the Ansible Roles in this Ansible Collection; this increment to a later Ansible Core release will not impact execution of the Ansible Role’s code on the target/managed hosts.

Note: This would impact usage of the Ansible Roles in this Ansible Collection, if an end-user were to log onto a target host and attempted to run an Ansible Playbook as a localhost execution (in a similar way to running a shell script) because this would require the target host itself to have Ansible Core 2.12+ which may not be available for the OS major.minor version if released prior to Q4-2021.

Copy link
Member

@rhmk rhmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@berndfinger berndfinger merged commit 8312cea into sap-linuxlab:dev Nov 28, 2023
8 checks passed
@berndfinger berndfinger deleted the issue-507 branch November 28, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants