various roles: ansible-lint 6.22.0 cleanup

[berndfinger]

Solves issue #535 for the following roles:

• sap_netweaver_preconfigure
• sap_hana_preconfigure
• sap_hana_install
• sap_swpm
• sap_install_media_detect
• sap_hostagent

[rhmk]

Is the double quote irrelevant?

[berndfinger]

Probably not. We have the same syntax in all other roles as per output of:

$ cd (collection root)
$ grep -rn "changed_when" | grep " in "

Also, while working on fixing #555, I got the following error message when removing the double quotes from the that: statement in one of the assert tasks:

  ansible.builtin.assert:
    that: 'bind-utils' in ansible_facts.packages
                       ^ here
This one looks easy to fix. It seems that there is a value started
with a quote, and the YAML parser is expecting to see the line ended
with the same kind of quote. For instance:

    when: "ok" in result.stdout

Could be written as:

   when: '"ok" in result.stdout'

Or equivalently:

   when: "'ok' in result.stdout"

[rhmk]

Thanks for the explanation.

[rhmk]

LGTM