sap_hana_preconfigure: update kernel parameters for SLES

[Wabri]

Closes #337

[sean-freeman]

@Wabri I'm good with this, but before I approve - did you want to break it down so GRUB options can be altered independently? These are Ansible Tasks that apply to SUSE family already:

https://github.com/sap-linuxlab/community.sap_install/blob/main/roles/sap_hana_preconfigure/tasks/sapnote/2684254/configuration.yml

[Wabri]

@sean-freeman done, needed to change the condition on the GRUB mkconfig task to check if some of the items have changed the grub configuration

[sean-freeman]

lgtm 👍

[berndfinger]

@Wabri Please add me as a reviewer for all preconfigure roles, for sap_hana_install, and sap_swpm.
Regarding this PR, there are two ansible-lint errors which need to be solved, see https://github.com/sap-linuxlab/community.sap_install/actions/runs/7832505611/job/21371352104?pr=638.

Also, add a comment before the line in which you implement #noqa (example: https://github.com/Wabri/community.sap_install/blob/fb32d0d80c01a462793b17285856e1f9e7553470/roles/sap_hana_preconfigure/tasks/SLES/configuration.yml#L54C1-L54C69), similar to

community.sap_install/roles/sap_hana_preconfigure/tasks/RedHat/installation.yml

Line 39 in 7720d7a

# Reason for noqa: Avoid calling one more command for getting the currently enabled repos

. See also https://ansible.readthedocs.io/projects/lint/usage/#muting-warnings-to-avoid-false-positives (search for best practice in this chapter).

[Wabri]

@berndfinger good catch, I've update with noqa and some explanation

[Wabri]

@sean-freeman @berndfinger I've try a different approach to solve the problem using the meta module (https://docs.ansible.com/ansible/latest/collections/ansible/builtin/meta_module.html) and trigger the grub2 update only if one item cause the change of the grub configuration. Let me know if it's clean enough for both of you.

[sean-freeman]

lgtm 👍 novel way of achieving the outcome, cool

[marcelmamula]

@sean-freeman @berndfinger I've try a different approach to solve the problem using the meta module (https://docs.ansible.com/ansible/latest/collections/ansible/builtin/meta_module.html) and trigger the grub2 update only if one item cause the change of the grub configuration. Let me know if it's clean enough for both of you.

Interesting use of meta module, but can you retest it few times and inside of wrapper?
My use of meta with end_play yielded inconsistent behavior across multiple nodes in wrapped play so I am hesitant to use it.

I had to switch to use pause module for debugging instead of meta: end_play because of that.