fix(ansible-test-sanity): update workflow to run in every pr #652
Conversation
Wabri
force-pushed
the
feature/648/ansible-test-sanity
branch
from
58a6095 to
40558c7
Compare
|
This reverts 4fa8571. We had decided to change it to a schedule in the past, because it has little value to see this check failing for the overall collection in any PR that only contains code changes in a role that is actually clean itself. That's what the role checks are for, to limit the lint checking to the parts that are affected by the PR, and where the result has a meaning for the particular PR. |
Only in part: The workflow for ansible-linting the collection will not be modified. The reason why I suggested to modify the trigger for the Ansible sanity testing is this issue, plus the low overhead for running this workflow. With this fix, errors outside of roles can be detected (and fixed) early and we will less likely overlook them. |
|
After the approval from @ja9fuchs + @berndfinger I'll merge the pr |
|
@Wabri Andiamo! :-) |
|
@berndfinger procedo! |
|
FYI: https://github.com/sap-linuxlab/community.sap_install/actions/runs/7933809574/job/21663414670?pr=653 proves that it is working as expected. |
Closes #648