-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(workflows): create a workflow to open issue when outdate deps #657
Conversation
6ec6c2c
to
5505a71
Compare
5505a71
to
5b2fa12
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for this PR :-) as of this announcement https://forum.ansible.com/t/devtools-projects-transitioning-to-calver-releases/3444 the dev tools are migrated to calver instead of semver maybe we should test this with the new version layout as well ? |
The actual version we are using are:
With the CalVer Releases the workflow not change and the reason is for this We should not worry about this new versioning 😃 |
This is good PR, but I do not understand why it is better than dependabot or why dependabot does not suit the needs. Could you please elaborate. |
This is not better than dependabot, is simply different and we can manage by ourself if we need some kind of specific feature. This is https://github.com/Wabri/community.sap_install/pull/20 an example of PR that dependabot open, if we choose that is the one we want we can go for it. I've open the dependabot pr to choose what is the best solution for us #659 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - is a good improvement to get early notifiers with issues on urgent fixes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great idea to get notified of such updates.
I like that it opens an issue and allows us to follow up later or ignore a change. Especially useful to first review the effect of frequent changes with impact like ansible-lint updates across the entire collection.
45ecf33
to
67c9e59
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (however, I didn't test).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
To test this, we should merge to main. is it ok for all of you? |
a041706
to
15a9031
Compare
Refs discussion#421
It is possible to use the github-action user to open issue
the check update dependencies will run on the first and the 15th day of the month
15a9031
to
de8b054
Compare
Refs #421 (comment)