Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workflows): create a workflow to open issue when outdate deps #657

Merged
merged 7 commits into from
Mar 5, 2024

Conversation

Wabri
Copy link
Member

@Wabri Wabri commented Feb 13, 2024

@Wabri Wabri marked this pull request as draft February 13, 2024 17:55
@Wabri Wabri changed the base branch from main to dev February 13, 2024 17:56
@Wabri Wabri force-pushed the experiment/discussion/421 branch 2 times, most recently from 6ec6c2c to 5505a71 Compare February 13, 2024 18:27
@Wabri Wabri self-assigned this Feb 13, 2024
@Wabri Wabri added the enhancement New feature or request label Feb 13, 2024
@Wabri Wabri force-pushed the experiment/discussion/421 branch from 5505a71 to 5b2fa12 Compare February 13, 2024 18:39
@berndfinger berndfinger self-requested a review February 14, 2024 08:11
Copy link
Member

@berndfinger berndfinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rainerleber
Copy link
Contributor

rainerleber commented Feb 14, 2024

Thanks for this PR :-) as of this announcement https://forum.ansible.com/t/devtools-projects-transitioning-to-calver-releases/3444 the dev tools are migrated to calver instead of semver maybe we should test this with the new version layout as well ?

@Wabri
Copy link
Member Author

Wabri commented Feb 14, 2024

The actual version we are using are:

ansible==9.1.0
ansible-compat==4.1.10
ansible-core==2.16.2
ansible-lint==6.22.1

With the CalVer Releases the workflow not change and the reason is for this delta=$(( ${version1_splitted[i]} - ${version2_splitted[i]} )) that you can find here. The delta is the distance between the current version and the latest and if this value is less than 0 the package must be update.

We should not worry about this new versioning 😃

@Wabri Wabri marked this pull request as ready for review February 14, 2024 11:50
@kksat
Copy link
Contributor

kksat commented Feb 14, 2024

This is good PR, but I do not understand why it is better than dependabot or why dependabot does not suit the needs.

Could you please elaborate.

@Wabri
Copy link
Member Author

Wabri commented Feb 14, 2024

This is not better than dependabot, is simply different and we can manage by ourself if we need some kind of specific feature.

This is https://github.com/Wabri/community.sap_install/pull/20 an example of PR that dependabot open, if we choose that is the one we want we can go for it.

I've open the dependabot pr to choose what is the best solution for us #659

@sean-freeman sean-freeman removed their request for review February 14, 2024 18:39
Copy link
Member

@rhmk rhmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - is a good improvement to get early notifiers with issues on urgent fixes

Copy link
Contributor

@ja9fuchs ja9fuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great idea to get notified of such updates.
I like that it opens an issue and allows us to follow up later or ignore a change. Especially useful to first review the effect of frequent changes with impact like ansible-lint updates across the entire collection.

@Wabri Wabri requested a review from sean-freeman February 20, 2024 17:03
@sean-freeman sean-freeman removed their request for review February 21, 2024 11:07
@Wabri Wabri marked this pull request as draft March 1, 2024 15:05
@Wabri Wabri marked this pull request as ready for review March 5, 2024 11:28
@Wabri Wabri force-pushed the experiment/discussion/421 branch 2 times, most recently from 45ecf33 to 67c9e59 Compare March 5, 2024 11:50
@Wabri
Copy link
Member Author

Wabri commented Mar 5, 2024

  • fix sanity issues
  • update and improve the open issue description
  • add cron schedule to run the 1st and 15th of the month, plus is possible to run manually

@Wabri Wabri requested review from rhmk and berndfinger March 5, 2024 12:04
Copy link
Member

@berndfinger berndfinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (however, I didn't test).

Copy link
Member

@rhmk rhmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wabri
Copy link
Member Author

Wabri commented Mar 5, 2024

To test this, we should merge to main. is it ok for all of you?

@Wabri Wabri changed the base branch from dev to main March 5, 2024 14:20
@Wabri Wabri force-pushed the experiment/discussion/421 branch from a041706 to 15a9031 Compare March 5, 2024 14:21
@Wabri Wabri marked this pull request as draft March 5, 2024 14:21
@Wabri Wabri force-pushed the experiment/discussion/421 branch from 15a9031 to de8b054 Compare March 5, 2024 14:29
@Wabri Wabri marked this pull request as ready for review March 5, 2024 14:29
@Wabri Wabri merged commit d36cc15 into sap-linuxlab:main Mar 5, 2024
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants