-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sap_*_preconfigure: Tests with ansible parameter -i instead of -l #671 #672
Conversation
Hi @streitd, |
@berndfinger Your code has been merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait! We need to merge into dev, not in main.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to modify the destination branch to main
but this would lead to lots of other changes to be reverted.
@streitd Can you please create a new PR with all the changes but based on the upstream dev tree?
I just created #680. Will close this PR now. |
This PR is changing ansible-playbook parameter
-l
to-i
in tests scripts.No more need to specify hosts in the file
/etc/ansible/hosts
each time.