sap_hana_install: Fix issue 756 #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All the fapolicyd tasks are now inside blocks which are only active when sap_hana_install_use_fapolicyd is true. Signed-off-by: Bernd Finger <[email protected]>
|
@berndfinger Cosmetical, but I think you can apply the tag of the tasks to the block now, instead all individual tasks? In any case, merging soon would be nice, since this issue currently breaks the HANA post-inst. :) |
Also fix some fapolicyd task names. Signed-off-by: Bernd Finger <[email protected]>
ja9fuchs
reviewed
Jun 18, 2024
Signed-off-by: Bernd Finger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two of the tasks were enabled even when
sap_hana_install_use_fapolicydwas set tofalse. This PR fixes the issue and ensures that all the fapolicyd tasks are now inside blocks which are only active whensap_hana_install_use_fapolicydistrue.