sap_general_preconfigure: Don't ignore DNS A/PTR record inconsistencies, this should fail the check is negative

[rob0d]

Also included a minor task description change to make it clearer what has failed.

[sean-freeman]

Would suggest the Ansible Tasks are updated as suggested in #743 to correctly indicate to the end-user, that dig runs from the host to check the DNS Resolver contains the A/PTR records.

• Check DNS Resolver in resolv.conf contains A Record for host
• Check DNS Resolver in resolv.conf contains reverse PTR Record for host

Otherwise I'd say this PR is an easy one to merge 👍

[berndfinger]

Would suggest the Ansible Tasks are updated as suggested in #743 to correctly indicate to the end-user, that dig runs from the host to check the DNS Resolver contains the A/PTR records.

• Check DNS Resolver in resolv.conf contains A Record for host
• Check DNS Resolver in resolv.conf contains reverse PTR Record for host

We should not include one specific DNS name resolution method because there are other methods which do not rely on an entry in /etc/resolv.conf. But I agree that the task names can be more detailed, as in:

• Verify the correct DNS hostname to IP address resolution (A record) using the FQDN
• Verify the correct DNS hostname to IP address resolution (A record) using the hostname and the search list
• Verify the correct DNS IP address to FQDN resolution (PTR record)

Just for the records: This check can be skipped by using the tag sap_general_preconfigure_dns_name_resolution in --skip-tags, so there should be no need to add another role parameter for this purpose.

[berndfinger]

typo: resolv.con -> resolv.conf

[rob0d]

@berndfinger @sean-freeman I've updated it again to improve the text based on the latest recommendation from both of you. Is this acceptable now?

[sean-freeman]

lgtm 👍 Would prefer mention of DNS Resolver is what is being verified, but I'm not going to hold up a simple fix for such acute purposes

[berndfinger]

LGTM