Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap_ha_pacemaker_cluster: Enhance corosync totem handling #790

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

marcelmamula
Copy link
Contributor

Changes:

  • Add __sap_ha_pacemaker_cluster_corosync_totem_default in OS variable files with baseline corosync totem settings
  • Add __sap_ha_pacemaker_cluster_corosync_totem_platform in Platform variable files with recommended corosync totem settings
  • Rework logic inside of construct_vars_common.yml to become dynamic - Platform totem is combined with OS totem, where Platform can overwrite OS values as required.
# Prepare corosync totem variable with either:
# - User provided sap_ha_pacemaker_cluster_corosync_totem if present
# - Combine corosync totem from OS variables and Platform variables if present
# - Use default corosync totem from OS variables if Platform variable is not present

Tested on:

  • SLES15 SP5 - SAP ASCS/ERS and HANA clusters

Note 1:
This change is now applicable to SUSE after changes in ha_cluster linux-system-roles/ha_cluster#212

Note 2:
Platform specific totem values are taken from comprehensive configuration in crmsh https://github.com/ClusterLabs/crmsh/blob/master/etc/profiles.yml

@marcelmamula marcelmamula added the enhancement New feature or request label Jul 2, 2024
@marcelmamula marcelmamula self-assigned this Jul 2, 2024
Copy link
Contributor

@ja9fuchs ja9fuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@sean-freeman sean-freeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very sensible/logical approach, lgtm 👍

@marcelmamula marcelmamula merged commit 5d0956a into sap-linuxlab:dev Jul 3, 2024
3 of 4 checks passed
@marcelmamula marcelmamula deleted the corosync branch July 9, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants