sap_ha_install_anydb_ibmdb2: linting and sles bug fixes #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berndfinger
reviewed
Jul 16, 2024
roles/sap_ha_install_anydb_ibmdb2/tasks/db2_hadr_pcmk_cluster_create.yml
Outdated
Show resolved
Hide resolved
berndfinger
reviewed
Jul 16, 2024
berndfinger
reviewed
Jul 16, 2024
berndfinger
reviewed
Jul 16, 2024
roles/sap_ha_install_anydb_ibmdb2/tasks/platform/db2cm_cloud_msazure_vm.yml
Outdated
Show resolved
Hide resolved
berndfinger
reviewed
Jul 16, 2024
roles/sap_ha_install_anydb_ibmdb2/tasks/platform/db2cm_cloud_msazure_vm.yml
Outdated
Show resolved
Hide resolved
|
@sean-freeman I found several tasks (despite the ones I mentioned before) where the Ansible module comes after registering its output. We already have two different places for a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added linting fixes and appended additional logic to provide further idempotency
At request and in parallel, tested with SLES 15 SP5 +
IBM Db2 for LUW 11.5 MP8 FP0 SAP2 LINUX x86_64and provided bug fixes accordingly. Db2 version was chosen to assess compatibility of older release with latest patched OS