Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collection: Modify for latest yamllint requirements #811

Merged
merged 2 commits into from
Jul 19, 2024

Conversation

berndfinger
Copy link
Member

ansible-lint 24.7.0 produced:

WARNING  Found incompatible custom yamllint configuration (.yamllint.yml), please either remove the file or edit it to comply with:
  - comments.min-spaces-from-content must be 1
  - octal-values.forbid-implicit-octal must be true
  - octal-values.forbid-explicit-octal must be true.

This PR ensures that the collection is yamllint clean again.

Relates to issue #810.

Solves issue sap-linuxlab#810.

Signed-off-by: Bernd Finger <[email protected]>
Also add "require-starting-space: false" because the former triggers 117
violations of "Missing starting space in comment".

Signed-off-by: Bernd Finger <[email protected]>
Copy link
Member

@sean-freeman sean-freeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Copy link
Member

@Wabri Wabri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 1 question

@berndfinger berndfinger merged commit 48031f0 into sap-linuxlab:dev Jul 19, 2024
6 of 7 checks passed
@berndfinger berndfinger deleted the issue-810-yaml-octal-values branch July 19, 2024 14:33
berndfinger added a commit to berndfinger/community.sap_install that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants