Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap_general_preconfigure: Use FQCN for import_role #827

Merged

Conversation

berndfinger
Copy link
Member

We need to use the FQCN when importing the role sap_maintain_etc_hosts.

Solves issue #826.

We need to use the FQCN when importing the role sap_maintain_etc_hosts.

Solves issue sap-linuxlab#826.

Signed-off-by: Bernd Finger <[email protected]>
Copy link
Contributor

@marcelmamula marcelmamula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ja9fuchs ja9fuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@berndfinger berndfinger removed the request for review from sean-freeman July 31, 2024 06:54
@berndfinger berndfinger merged commit 5884a30 into sap-linuxlab:dev Jul 31, 2024
3 of 4 checks passed
@berndfinger berndfinger deleted the issue-826-add-fqcn-to-include_role branch July 31, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants