sap_swpm: New improved and simplified version

[berndfinger]

I am providing an improved and simplified version of the role sap_swpm, with the following features:

• No longer use separate role modes while keeping the same functionality.
• Enable creating the sapinst input file inifile.params using both methods (inifile sections and direct parameter setttings), similar to combining the default and advanced modes of the previous version. In the first step (but only if the role parameter sap_swpm_inifile_sections_list is defined), the new sap_swpm version is creating the file inifile.params from the inifile sections in the template. Then, if the parameter sap_swpm_inifile_parameters_dict is defined, existing variable definitions can be modified, or additional variables and their settings can be added at the end of the file. This provides maximum flexibility for creating the file inifile.params while not increasing the complexity of the logic.
• No longer use the 3 or 4 level dictionary sap_swpm_inifile_custom_values_dictionary (for setting role variables) inside the role, as it was required for the previous modes default_templates and advanced_templates. The dictionary can still be used and maintained, by setting certain top level role parameters from dictionary members. Note: You cannot access low level dictionary members using a variable which has been defined in the same task. For defining mid-level variables of a dictionary, you have to use a separate task (e.g. set_fact) before.
• Enable creating a sapinst inifile.params parameter input file within a few seconds (using tag sap_swpm_generate_inifile), without running pre_install steps. This file can then be transferred to managed nodes, to be re-used later, even by the role sap_swpm for running unattended installations.
• Similar to the role sap_hana_install (parameter sap_hana_install_configfile_directory), the new version of sap_swpm is now checking for an existing installer input file on the managed node (parameter sap_swpm_inifile_directory), not on the control node.

[berndfinger]

Note: I successfully tested with ap4s scenarios sap_s4hana_sandbox and sap_s4hana_standard on AWS. Testing with sap_s4hana_distributed_ha is still ongoing.

[marcelmamula]

Some small changes needed, while I continue testing.

[berndfinger]

Successfully tested with AP4S scenarios:

• sap_s4hana_distributed_ha
• sap_s4hana_distributed
• sap_hana_scaleout
• sap_hana_ha and
• sap_hana

on AWS, using the dictionary sap_swpm_templates_install_dictionary and SAP S/4HANA Foundation 2023.

Note: Variables defined inside the dictionary sap_swpm_templates_install_dictionary have precedence over the variables with the same name defined on the top level (=with global scope), if any. Example:

sap_hana_install_media_dictionary:
  sap_s4hana_2023_distributed_nwas_ascs:
    sap_swpm_product_catalog_id: NW_ABAP_ASCS:S4HANA2023.FNDN.HDB.ABAP
    sap_swpm_inifile_list:
      - swpm_installation_media
      - swpm_installation_media_swpm2_hana
      - credentials
    sap_swpm_inifile_dictionary:
      sap_swpm_install_saphostagent: 'true'

If the variable sap_swpm_install_saphostagent is defined to false separately (e.g. by set_fact in another play of the same playbook), such a definition will be ignored and the value of true will be taken from sap_swpm_install_saphostagent defined inside sap_swpm_templates_install_dictionary. The same applies to sap_swpm_product_catalog_id and to sap_swpm_inifile_list.

The role is using set_fact to set such variables on the top level (=with global scope), so be sure to set these variables to the desired value (e.g. in the vars: section) when calling the role again in the same playbook (even if it's in a different play).

[marcelmamula]

Additional changes that would be good to include:

1. remove /etc/hosts steps and replace them with /etc/hosts role instead.
2. Correct non-standard variable inputs like sap_swpm_use_password_file == "y"

I found them while updating Readme.

[rhmk]

LGTM

[marcelmamula]

LGTM, Thank you @berndfinger for patiently testing and fixing all issues with me to hopefully resolve all issues before merging.

[ja9fuchs]

Successfully tested an ASCS/ERS installation. 👍