Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap_ha_pacemaker_cluster: GCP haproxy handling and new platform VIP dictionary #862

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

marcelmamula
Copy link
Contributor

Changes

  1. GCP Preconfigure task was moved to block to execute only if proper gcp_nlb_reserved_ip_haproxy method is used. This is not necessary for ipaddr method.
  2. New __sap_ha_pacemaker_cluster_sap_extra_packages_dict dictionary in OS var files to accommodate override over default VIP method. This is similar dictionary implementation as done before for stonith, extra packages and others.

Reason

haproxy is not documented method to be used on SUSE as per documentation from Google.

# SUSE - VIP: IPaddr2, Healthcheck: No pacemaker resources, but directly as part of NLB healthcheck
#   HANA: https://cloud.google.com/solutions/sap/docs/sap-hana-ha-config-sles#create_a_local_cluster_ip_resource_for_the_vip_address
#   NWAS: https://cloud.google.com/solutions/sap/docs/netweaver-ha-config-sles#create_the_vip_resources
# RHEL - VIP: IPaddr2, Healthcheck: haproxy
#   HANA: https://cloud.google.com/solutions/sap/docs/sap-hana-ha-config-rhel#create_a_virtual_ip_address_resource
#   NWAS: https://cloud.google.com/solutions/sap/docs/netweaver-ha-config-rhel#create_a_virtual_ip_address_resource

@marcelmamula marcelmamula added the enhancement New feature or request label Sep 11, 2024
@marcelmamula marcelmamula self-assigned this Sep 11, 2024
Copy link
Contributor

@ja9fuchs ja9fuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, adds flexibility to the VIP methods per platform and OS

@marcelmamula marcelmamula merged commit 4116bb0 into sap-linuxlab:dev Sep 11, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants