Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap_swpm: add functionality to set specific DDIC and SAP* passwords during new installation #874

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

rob0d
Copy link
Contributor

@rob0d rob0d commented Oct 8, 2024

Fix for issue #764 and replacement of pull request #763

Copy link
Contributor Author

@rob0d rob0d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "fix" in pull request #763 was incorrect, so restored the original functionality (related to system copies) and added the correct config in the jinja template.

@sean-freeman
Copy link
Member

sean-freeman commented Dec 5, 2024

To match 1.5.x updated style, and create future proof naming..... I would suggest and will test the below

{% if sap_swpm_ddic_000_password | d('',true) | length > 0 %}

###################################################################
# BEGIN section credentials_install_ddic_000                      #
#                                                                 #
NW_CI_Instance_ABAP_Reports.needNewDDIC000Password = true
NW_CI_Instance_ABAP_Reports.ddic000Password = {{ sap_swpm_ddic_000_password }}
#                                                                 #
#  END  section credentials_install_ddic_000                      #
###################################################################
{% endif %}
{% if sap_swpm_sapstar_000_password | d('',true) | length > 0 %}

###################################################################
# BEGIN section credentials_install_sapstar_000                   #
#                                                                 #
NW_CI_Instance_ABAP_Reports.needNewSapStar000Password = true
NW_CI_Instance_ABAP_Reports.sapStar000Password = {{ sap_swpm_sapstar_000_password }}
#                                                                 #
#  END  section credentials_install_sapstar_000                   #
###################################################################
{% endif %}
{% if 'credentials_syscopy_ddic_000' in sap_swpm_inifile_sections_list %}

###################################################################
# BEGIN section credentials_syscopy_ddic_000                      #
#                                                                 #
NW_DDIC_Password.needDDICPasswords = true
NW_DDIC_Password.ddic000Password = {{ sap_swpm_ddic_000_password | default(sap_swpm_master_password) }}
#NW_DDIC_Password.ddic001Password =
#                                                                 #
#  END  section credentials_syscopy_ddic_000                      #
###################################################################
{% endif %}

@rob0d
Copy link
Contributor Author

rob0d commented Dec 6, 2024

Sean, do you want me to do a commit as per the above or will you update it?

@sean-freeman
Copy link
Member

@rob0d To preserve your commit / effort, it has to be done by yourself. Likely requires a git rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants