sap_netweaver_preconfigure: Sync with applicable SAP notes for Adobe DS #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solves issue sap-linuxlab#689. Further changes in this commit: - Add the SAP note numbers and versions in a comment before the list of packages in the RedHat*.yml files in vars. - Add 'ansible_architecture' as a condition in the related installation task, so that there is no task failure when running on another architecture than 'x86_64'. - Also revert back to the default of 'false' for the role variable 'sap_netweaver_preconfigure_use_adobe_doc_services'. See commit 384f4d8, PR sap-linuxlab#876. Signed-off-by: Bernd Finger <[email protected]>
ja9fuchs
approved these changes
Nov 19, 2024
marcelmamula
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
@berndfinger @ja9fuchs LGTM, but it is good to start planning readme update to reflect (RedHat specific) variables so it is not confusing. I have updated (SUSE specific) already, but this one is good example of (RedHat specific) variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #689.
Further changes in this commit:
Add the SAP note numbers and versions in a comment before the list of packages in the RedHat*.yml files in vars.
Add 'ansible_architecture' as a condition in the related installation task, so that there is no task failure when running on another architecture than 'x86_64'.
Also revert back to the default of 'false' for the role variable 'sap_netweaver_preconfigure_use_adobe_doc_services'. See commit 384f4d8, PR sap_netweaver_preconfigure/SUSE: Fix for issue 868 specific to SLES4SAP15 SP6 #876.