Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap_*_preconfigure, sap_ha_pacemaker_cluster: Vars loading reworked, Linting fixes for yes/no #910

Merged
merged 5 commits into from
Dec 9, 2024

Conversation

marcelmamula
Copy link
Contributor

@marcelmamula marcelmamula commented Dec 9, 2024

Description:

  1. Add vars file loading in line with linux-system-roles to load in order and remove duplicated variables.
  2. Correct linting errors of yes, no across preconfigure roles
  3. Removed expect dependency from sap_ha_pacemaker_cluster role for Suse post tasks.
  4. Ensure fapolicyd is installed only on RedHat in sap_hana_install
# Load variable files in order:
# Example for SUSE Linux Enterprise Server for SAP Applications 15 SP6:
# 1. Suse.yml - Specific to OS family.
# 2. SLES_15.yml - Specific to distribution (SLES and SLES_SAP) and major release.
# 3. SLES_15.6.yml - Specific to distribution (SLES and SLES_SAP) and minor release.
# 4. SLES_SAP_15.yml - Specific to distribution SLES_SAP and major release.
# 5. SLES_SAP_15.6.yml - Specific to distribution SLES_SAP and minor release.

Tested

Tested end to end SAP HANA HA and SAP ASCS/ERS cluster on SLES4SAP 15 SP6 on AWS and Google Cloud.

Next steps

  • @berndfinger Please check RedHat var files to simplify them in separate PR as we discussed: Put shared parameters into RedHat.yml and version specific in their own files.

@marcelmamula marcelmamula added the enhancement New feature or request label Dec 9, 2024
@marcelmamula marcelmamula self-assigned this Dec 9, 2024
@marcelmamula marcelmamula changed the title sap_install_*_preconfigure, sap_install_ha*: Vars loading reworked, Linting fixes for yes/no sap_*_preconfigure, sap_install_ha*: Vars loading reworked, Linting fixes for yes/no Dec 9, 2024
@marcelmamula marcelmamula changed the title sap_*_preconfigure, sap_install_ha*: Vars loading reworked, Linting fixes for yes/no sap_*_preconfigure, sap_ha_pacemaker_cluster: Vars loading reworked, Linting fixes for yes/no Dec 9, 2024
Copy link
Member

@berndfinger berndfinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the RHEL related and non-HA parts.

Copy link
Contributor

@ja9fuchs ja9fuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look fine.
Cluster setup tested and all good.
Vars loading tested and the output is looking good now too.
👍

@marcelmamula marcelmamula merged commit a96da30 into sap-linuxlab:dev Dec 9, 2024
7 of 8 checks passed
@sean-freeman
Copy link
Member

Not that it's needed to be said, but - this is a very good cleanup commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants