Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap_ha_pacemaker_cluster: ANGI on RHEL and small improvements #911

Merged
merged 9 commits into from
Dec 10, 2024

Conversation

ja9fuchs
Copy link
Contributor

@ja9fuchs ja9fuchs commented Dec 9, 2024

Description

  1. "ANGI" now also works on RHEL

    • RHEL pre-steps discover the package but will not resolve the package conflict if the classic agents are installed. A failure message explains the issue and the user has to solve it. This will prevent an unintended change of the entire setup if run against pre-configured nodes.
    • Adjustment of the VIP order constraint task to work with classic and 'angi'.
  2. Adjustment of hook vars logic

    • Explicitly define hook preferences for _tkover and _chksrv vars in OS defaults.
    • The hook task now respects the hook control variable and the argument now works for user choices, overriding the OS preference.
    • The presence of the hook definition in the OS vars does not enforce the hook config anymore. This enables the definition of optional hooks.
    • In RHEL the _chksrv hook is also available and supported. The hook is optional, for customers to enable on demand.
  3. A few cosmetical improvements of task names

  4. Suspected typo fixed for __sap_ha_pacemaker_cluster_hanacontroller_resource_clone_name

    • I could not find a reference to mst_ and the argument default info also refers to cln_ as the prefix.

Tested

  • ... on RHEL 9.4 in AWS for SAP HANA HA with 'classic' and 'angi' resource agents.
  • Verified the hook enable choice to configure the hook that is not enabled by default on RHEL.

@ja9fuchs ja9fuchs requested a review from marcelmamula December 9, 2024 16:19
Copy link
Contributor

@marcelmamula marcelmamula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with mst/cln changes

roles/sap_ha_pacemaker_cluster/tasks/include_vars_hana.yml Outdated Show resolved Hide resolved
@ja9fuchs ja9fuchs merged commit 0686f6c into sap-linuxlab:dev Dec 10, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants