Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge dev to main for release 1.5.2 #943

Merged
merged 23 commits into from
Jan 24, 2025
Merged

merge dev to main for release 1.5.2 #943

merged 23 commits into from
Jan 24, 2025

Conversation

berndfinger
Copy link
Member

No description provided.

marcelmamula and others added 23 commits January 14, 2025 13:50
Fixes issue #934.

Signed-off-by: Bernd Finger <[email protected]>
New codespell error after codespell update from 2.3.0 to 2.4.0

Signed-off-by: Bernd Finger <[email protected]>
sap_*_preconfigure/Suse: Rework of preconfigure roles for Suse, add missing notes.
I am not aware of any issues related to missing English locales on RHEL
7, so we can safely assume that a RHEL 7 system will have all necessary
English locale packages installed as part of installing the mandatory
software environment group.

Signed-off-by: Bernd Finger <[email protected]>
sap_general_preconfigure: Fix check mode
sap_general_preconfigure: No longer install locale packages in RHEL 7
sap_*_preconfigure: Add code for RHEL 10 support
Solves #939.

Also moved sap_netweaver_preconfigure_packages to a similar place as
in the other preconfigure roles and added this variable to README.md

Signed-off-by: Bernd Finger <[email protected]>
sap_netweaver_preconfigure: fix argument_specs validation error
Copy link
Contributor

@marcelmamula marcelmamula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good job @berndfinger

Copy link
Contributor

@ja9fuchs ja9fuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 tested yesterday on dev

@berndfinger berndfinger merged commit 9ee20c7 into main Jan 24, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants