-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge dev to main for release 1.5.2 #943
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to #833. Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
Fixes issue #934. Signed-off-by: Bernd Finger <[email protected]>
New codespell error after codespell update from 2.3.0 to 2.4.0 Signed-off-by: Bernd Finger <[email protected]>
sap_*_preconfigure/Suse: Rework of preconfigure roles for Suse, add missing notes.
I am not aware of any issues related to missing English locales on RHEL 7, so we can safely assume that a RHEL 7 system will have all necessary English locale packages installed as part of installing the mandatory software environment group. Signed-off-by: Bernd Finger <[email protected]>
sap_general_preconfigure: Fix check mode
sap_general_preconfigure: No longer install locale packages in RHEL 7
sap_*_preconfigure: Add code for RHEL 10 support
Solves #939. Also moved sap_netweaver_preconfigure_packages to a similar place as in the other preconfigure roles and added this variable to README.md Signed-off-by: Bernd Finger <[email protected]>
sap_netweaver_preconfigure: fix argument_specs validation error
Signed-off-by: Bernd Finger <[email protected]>
Signed-off-by: Bernd Finger <[email protected]>
collection: prepare for v1.5.2
marcelmamula
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Good job @berndfinger
ja9fuchs
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 tested yesterday on dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.