Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ensure #226

Merged
merged 2 commits into from
Nov 26, 2024
Merged

fix ensure #226

merged 2 commits into from
Nov 26, 2024

Conversation

chuan137
Copy link
Member

  • sapcc: continue to next share server when error raised
  • sapcc: continue to ensure next share instance on NotFound error

@chuan137
sapcc: continue to next share server when error raised
a0cd695 
Deleting share server can fail due to foreign key constraints on the
field 'source_share_server_id'. We can log a message and continue to
deleting other share servers.

Also adjust the message levels are changed from error to warning in this
method. No need to send them to sentry.

Change-Id: If8f95c863e9dce7d09f681ed8b6e08c23370904f
@chuan137
sapcc: continue to ensure next share instance on NotFound error
c22b3b0 
Share instance may be deleted in the meanwhile. Ignore the error and
less noises in sentry.

Change-Id: I24eceb64c9511928fbbedc65e425ce6ae39f08a9
@Carthaca Carthaca merged commit a9ade7b into stable/xena-m3 Nov 26, 2024
2 checks passed
@Carthaca Carthaca deleted the fix-ensure branch November 26, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Carthaca Carthaca Carthaca approved these changes

@kpawar-sap kpawar-sap kpawar-sap approved these changes

@sumitarora2786 sumitarora2786 Awaiting requested review from sumitarora2786 sumitarora2786 is a code owner

@crenduchinta88 crenduchinta88 Awaiting requested review from crenduchinta88 crenduchinta88 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chuan137 @Carthaca @kpawar-sap