Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

purge deleted clone #229

Draft
wants to merge 1 commit into
base: stable/xena-m3
Choose a base branch
from
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions manila/share/drivers/netapp/dataontap/client/client_cmode.py
Original file line number Diff line number Diff line change
Expand Up @@ -4222,6 +4222,21 @@ def prune_deleted_volumes(self):
"volume %s", volume_name)
else:
for clone in clones:
"""TODO:
if clone.type == DEL:
recovery_queue.purge(clone)

reasoning: we have a soft deleted volume that
is going to be deleted, but it can't because it
non-split child is still in the recovery queue.
Let's remove the child for good (alternative would
be to recover, split, delete the child again)
We don't promise restore for complex parent-child
relationships. And anyhow this is only a problem
if clone split was not fast enough, which means
the volume is short-lived
(aka qualifies for force delete).
"""
try:
clone_status = client.volume_clone_split_status(
clone)
Expand Down