Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip cache for failover status checks. #255

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

velp
Copy link
Contributor

@velp velp commented Feb 26, 2024

This PR removes the cache from F5 status checking to have correct statuses during the failover check.

Related to #212

@velp velp self-assigned this Mar 5, 2024
Copy link
Contributor

@m-kratochvil m-kratochvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, discussed in the Octavia meeting

Copy link
Collaborator

@BenjaminLudwigSAP BenjaminLudwigSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd have to check but I think this introduces superfluous checks. That should not be a problem however, so I will simply remove them in a refactoring PR in the future.

@BenjaminLudwigSAP BenjaminLudwigSAP merged commit e640c77 into stable/yoga-m3 Mar 5, 2024
3 checks passed
@BenjaminLudwigSAP BenjaminLudwigSAP deleted the issue_212_fix_failover branch March 5, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants