Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default name for scoped presets and tasks #185

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ext
Copy link
Collaborator

@ext ext commented Jul 8, 2021

Allows a shorter syntax for scoped packages.

Instead of:

  • @mycompany/mrm-preset
  • @mycompany/mrm-preset-unicorn

we can now write:

  • @mycompany (resolves to @mycompany/mrm-preset)
  • @mycompany/unicorn (resolves to @mycompany/mrm-preset-unicorn, this one actually works in master but not documented as far as I can find)

Why? Because I'm lazy.

Copy link
Owner

@sapegin sapegin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks! Just a tiny suggestion ;-)

packages/mrm/src/index.js Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #185 (2e44369) into master (5208741) will decrease coverage by 0.22%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
packages/mrm/src/index.js 100.00% <100.00%> (ø)
packages/mrm-task-license/index.js 96.15% <0.00%> (-3.85%) ⬇️
packages/mrm-task-eslint/index.js 97.29% <0.00%> (-2.71%) ⬇️
packages/mrm-core/src/npm.js 100.00% <0.00%> (ø)
packages/mrm-task-gitignore/index.js 100.00% <0.00%> (ø)
packages/mrm-task-package/index.js 97.67% <0.00%> (+1.84%) ⬆️

@ext ext force-pushed the feature/scoped-preset branch from 2e44369 to 98e08d8 Compare July 22, 2021 08:58
@ext ext force-pushed the feature/scoped-preset branch from 98e08d8 to 410bfbc Compare August 16, 2021 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants