Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/optional overlays/tempadmin #122

Closed
wants to merge 20 commits into from

Conversation

Menkveld-24
Copy link
Contributor

@Menkveld-24 Menkveld-24 commented Apr 29, 2023

Implements #105 and #71

Also restyled the master controls layout:
Schermafbeelding 2023-05-10 om 00 13 05
Schermafbeelding 2023-05-10 om 00 13 45

@Menkveld-24 Menkveld-24 self-assigned this Apr 29, 2023
@Menkveld-24 Menkveld-24 requested a review from a team April 29, 2023 08:20
@Menkveld-24 Menkveld-24 changed the title Feature/optional overlays Feature/optional overlays/tempadmin May 9, 2023
@Menkveld-24 Menkveld-24 requested review from a team and removed request for a team May 9, 2023 22:16
class="dark:bg-proto_secondary_gray-dark -z-10 h-full max-w-none rounded-lg bg-white"
alt="Loading..." />
</div>
kutfotos
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not very professional of you :0

Copy link
Member

@ysbrandB ysbrandB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LAGTM,
I would make the default that you see the video and not the forced photos.
Also when you disable the photos and play the radio I think it would be better to show the radio logo or the name of the station big and not just a white screen.

@Menkveld-24 Menkveld-24 closed this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants