Add the option to shuffle playlists and swap the order of your songs. #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en videos of the same user)
|
I have now tested this with an admin user and a non admin user at the same time and the permissions work as expected. |
Menkveld-24
requested changes
Sep 26, 2024
server/.env.example
Outdated
There was a problem hiding this comment.
This doesnt need to be vite right?
Comment on lines
+96
to
+97
| } | ||
| if (up) { |
There was a problem hiding this comment.
Suggested change
| } | |
| if (up) { | |
| } else { |
| }; | ||
|
|
||
| const maxVideos = parseInt( | ||
| import.meta.env.VITE_USER_MAX_VIDEOS_IN_QUEUE ?? "20" |
There was a problem hiding this comment.
Deze importeer je toch via een .env in de client map? En niet via de .env in de server map?
There was a problem hiding this comment.
nee vite fixt dit automatisch voor je
Menkveld-24
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding a playlist you now get a modal that lets you choose if you want the playlist to be shuffled or not (see picture). It also informs non admins that only the first x songs get added. Fixes saproto/saproto#2218.
Also adds the option to swap videos that you have put in from position, and lets admins do that for other users.
This means if you have queue position 3 and 5 under the fair add system, you can press the up arrow on the song in position 3 or the down arrow in position 5 and than these two items will be swapped in the queue. See picture for the UI.