-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Package Cache #1
Conversation
🆗 Pre-flight checks passed 😃This pull request has been checked and contains no modified workflow files or spoofing. It should be safe to Approve and Run the workflows that need maintainer approval. |
Additionally, if you want to be able to update the package cache without cloning locally, you can add a |
Auto-generated via {sandpaper} Source : eb73856 Branch : main Author : Sarah Kaspar <[email protected]> Time : 2023-02-07 19:23:14 +0000 Message : Merge pull request #1 from zkamvar/znk-update-cache Update Package Cache
Auto-generated via {sandpaper} Source : 4d269f7 Branch : md-outputs Author : GitHub Actions <[email protected]> Time : 2023-02-07 19:26:53 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : eb73856 Branch : main Author : Sarah Kaspar <[email protected]> Time : 2023-02-07 19:23:14 +0000 Message : Merge pull request #1 from zkamvar/znk-update-cache Update Package Cache
Hi Zhian, Can I bother you with one more issue? Now that the website is up, the png-images that I store in the episodes/fig folder are only shown in the instructor view. Locally (on my computer in the RStudio viewer) all looks fine, in both learner and instructor view. I'd be very grateful for your feedback. |
Hi @sarahkaspar you could try removing the |
Yes, they do :) The lesson looks good now. Thank you for coming back to this Toby! |
@sarahkaspar this updates the package cache to avoid the error that was seen in carpentries/workbench#40
I have also removed the
renv/
folder inside of theepisodes/
folder. This was caused by a bug in sandpaper that I will fix in the next version: carpentries/sandpaper#391One other issue that I am seeing is that you have two setup documents in the learner folder:
https://github.com/sarahkaspar/biostatistics-course/blob/edadde9faeb94c9ab2cb490477656240e32be54d/learners/setup.Rmd and https://github.com/sarahkaspar/biostatistics-course/blob/edadde9faeb94c9ab2cb490477656240e32be54d/learners/setup.md
The Workbench considers the name of these files identical (because it treats markdown and Rmarkdown the same). Is there a reason for having two? I noticed that you are using the markdown version in the config, I am removing the R Markdown version.