-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve html templates for admin pages #71
base: main
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 12045764197Details
💛 - Coveralls |
import_export_extensions/templates/admin/import_export_extensions/celery_export_status.html
Outdated
Show resolved
Hide resolved
94cad55
to
950d244
Compare
950d244
to
4126e2e
Compare
@@ -0,0 +1,3 @@ | |||
{% load i18n %} | |||
|
|||
<progress max="100" id="progress-bar" data-url="{{ job_url }}" data-label={% trans "Waiting..." %}></progress> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<progress max="100" id="progress-bar" data-url="{{ job_url }}" data-label={% trans "Waiting..." %}></progress> | |
<progress max="100" id="progress-bar" data-url="{{ job_url }}" data-label={% translate "Waiting..." %}></progress> |
So I guess this package will help https://github.com/adamchainz/djade in such cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can leave trans
as it is everywhere else in the project, and then add djade
later
56e4b29
to
92368f2
Compare
92368f2
to
b20bfab
Compare
9e1c8a2
to
7387a44
Compare
Related to #68 and a few minor fixes)
Fix progress bar on changeview for ImportJob and ExportJob
Before:
After:
Improve celery-import-result page
Format
by file extensionTotals
section to celery import resultBefore:
After:
Improve progress bar style (#72)
Light theme:
Dark theme:
Remove useless code