Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve html templates for admin pages #71

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Eg0ra
Copy link
Contributor

@Eg0ra Eg0ra commented Nov 22, 2024

Related to #68 and a few minor fixes)

Fix progress bar on changeview for ImportJob and ExportJob

Before:

image

After:

image

Improve celery-import-result page
  • Add resources fields
  • Fix autofill Format by file extension
  • Add Totals section to celery import result

Before:

image

After:

image

Improve progress bar style (#72)

Light theme:

image
image

Dark theme:

image
image

Remove useless code

@Eg0ra Eg0ra self-assigned this Nov 22, 2024
@coveralls
Copy link

coveralls commented Nov 22, 2024

Pull Request Test Coverage Report for Build 12045764197

Details

  • 11 of 11 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 12023178983: 0.0%
Covered Lines: 1436
Relevant Lines: 1436

💛 - Coveralls

@Eg0ra Eg0ra mentioned this pull request Nov 22, 2024
@Eg0ra Eg0ra changed the title Improve progress bar on admin page Improve html templates for admin pages Nov 26, 2024
@Eg0ra Eg0ra force-pushed the feature/improve-admin-progress-bar branch 4 times, most recently from 94cad55 to 950d244 Compare November 26, 2024 05:36
@Eg0ra Eg0ra force-pushed the feature/improve-admin-progress-bar branch from 950d244 to 4126e2e Compare November 26, 2024 05:37
@Eg0ra Eg0ra marked this pull request as ready for review November 26, 2024 05:39
@@ -0,0 +1,3 @@
{% load i18n %}

<progress max="100" id="progress-bar" data-url="{{ job_url }}" data-label={% trans "Waiting..." %}></progress>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<progress max="100" id="progress-bar" data-url="{{ job_url }}" data-label={% trans "Waiting..." %}></progress>
<progress max="100" id="progress-bar" data-url="{{ job_url }}" data-label={% translate "Waiting..." %}></progress>

So I guess this package will help https://github.com/adamchainz/djade in such cases

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can leave trans as it is everywhere else in the project, and then add djade later

@Eg0ra Eg0ra force-pushed the feature/improve-admin-progress-bar branch 2 times, most recently from 56e4b29 to 92368f2 Compare November 26, 2024 07:26
@Eg0ra Eg0ra force-pushed the feature/improve-admin-progress-bar branch from 92368f2 to b20bfab Compare November 26, 2024 07:27
@Eg0ra Eg0ra force-pushed the feature/improve-admin-progress-bar branch from 9e1c8a2 to 7387a44 Compare November 27, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants