render h5p in iframe #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New H5P libraries have been added to Moodle core_h5p in /lib/h5p.
These are the issues identified by Amaia during her review.
Removed the autoloaded, added a temporary return to the t() method and renamed the preloaded_js and preloaded_css DB fields.
Amaia has reviewed how the display options work and has identified these changes (they should be moved to the Framework interface issue).
This patch is based on Bas first draft and adapted by Amaia to make it work with the new interfaces.
sarjona
force-pushed
the
MDL-66609-master-testing
branch
4 times, most recently
from
4d9a010 to
c727690
Compare
sarjona
force-pushed
the
MDL-66609-master-testing
branch
13 times, most recently
from
ec98553 to
13588ea
Compare
sarjona
pushed a commit
that referenced
this pull request
Aug 26, 2020
…settings Settings for dynamically reloading.
sarjona
added a commit
that referenced
this pull request
Feb 15, 2024
This patch fixes the following error: PHP Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated in lib/upgradelib.php on line 1299
sarjona
added a commit
that referenced
this pull request
Feb 15, 2024
This patch fixes the following error: PHP Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated in lib/upgradelib.php on line 1299
sarjona
added a commit
that referenced
this pull request
Feb 15, 2024
This patch fixes the following error: PHP Deprecated: explode(): Passing null to parameter #2 ($string) of type string is deprecated in lib/upgradelib.php on line 1299
sarjona
pushed a commit
that referenced
this pull request
Jun 14, 2024
This commit includes more changes, all them also adding the :void return type to unit tests missing them. The difference is that all these changes, while also detected perfectly by the moodle.PHPUnit.TestReturnType sniff, were not auto-fixed (like the previous commit ones), because all them do include some "return" statement and, for safety, we don't fix them. All the cases have been visually inspected and confirmed that the existing "return" statements always belong to anon functions within the test body and not the test own return statement.
sarjona
pushed a commit
that referenced
this pull request
Jun 18, 2024
This commit includes more changes, all them also adding the :void return type to unit tests missing them. The difference is that all these changes, while also detected perfectly by the moodle.PHPUnit.TestReturnType sniff, were not auto-fixed (like the previous commit ones), because all them do include some "return" statement and, for safety, we don't fix them. All the cases have been visually inspected and confirmed that the existing "return" statements always belong to anon functions within the test body and not the test own return statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*** PLEASE DO NOT OPEN PULL REQUESTS VIA GITHUB ***
The moodle.git repository at Github is just a mirror of the official repository. We do not accept pull requests at Github.
See CONTRIBUTING.txt guidelines for how to contribute patches for Moodle. Thank you.
--