MDL-66402 core_h5p: add manager class for storing h5p by url #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New H5P libraries have been added to Moodle core_h5p in /lib/h5p.
These are the issues identified by Amaia during her review.
Removed the autoloaded, added a temporary return to the t() method and renamed the preloaded_js and preloaded_css DB fields.
Amaia has reviewed how the display options work and has identified these changes (they should be moved to the Framework interface issue).
This patch is based on Bas first draft and adapted by Amaia to make it work with the new interfaces.
Instead of using the 'div', some code has been added to the view_assets for using 'iframe' always.
For fixing the issue when loading sounds and images from libraries.
This commit has been added temporary to help with the FileStorage implementation (the code should be reviewed and fixed to use the expected context). Some method has been added temporary from the mod_hvp (but it will be changed).
An extra field has been added to the h5p table to link any H5P file uploaded to the entry created in the H5P table.
sarjona
force-pushed
the
MDL-66402-master
branch
2 times, most recently
from
dadc3dd to
a11b55d
Compare
sarjona
force-pushed
the
MDL-66402-master
branch
from
a11b55d to
c933505
Compare
sarjona
pushed a commit
that referenced
this pull request
Aug 26, 2020
…refresh_button_option Setting to display/hide refresh button.
sarjona
pushed a commit
that referenced
this pull request
Sep 13, 2021
sarjona
pushed a commit
that referenced
this pull request
Sep 17, 2021
sarjona
pushed a commit
that referenced
this pull request
Oct 6, 2021
sarjona
pushed a commit
that referenced
this pull request
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*** PLEASE DO NOT OPEN PULL REQUESTS VIA GITHUB ***
The moodle.git repository at Github is just a mirror of the official repository. We do not accept pull requests at Github.
See CONTRIBUTING.txt guidelines for how to contribute patches for Moodle. Thank you.
--