Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INTERNAL][CORE] Removes deprecated methods from XMPPAccountStore #615

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[INTERNAL][CORE] Removes deprecated methods from XMPPAccountStore #615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8edfba
[INTERNAL][CORE] Amends XMPPAccountStore API
srossbach Jul 31, 2019
a6f20a1
[INTERNAL][UI] Use new XMPPStore API
srossbach Jul 31, 2019
a784970
[INTERNAL][CORE] Removes deprecated methods from XMPPAccountStore
srossbach Aug 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions core/src/saros/account/XMPPAccount.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ public final class XMPPAccount implements Serializable {
if (!domain.toLowerCase().equals(domain))
throw new IllegalArgumentException("domain url must be in lower case letters");

// FIXME see https://tools.ietf.org/html/rfc6122#section-2 - the localpart/username is also
// case-insensitive
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My assumption is that this means we should add a check (equivalent to the checks for server and domain above). Either way, I think it would be better to spell out exactly what you want to happen to ensure that the fixme is interpreted correctly.

Copy link
Contributor Author

@srossbach srossbach Aug 5, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem I have is I do not know how XStream works. What happens if we load the set after changing the equal method of this class ? Can I ensure that duplicates got removed or do I have to manually "fix" the set ?


if (port < 0 || port >= 65536) throw new IllegalArgumentException("port number is not valid");

if ((server.trim().length() != 0 && port == 0) || (server.trim().length() == 0 && port != 0))
Expand Down Expand Up @@ -136,8 +139,7 @@ public String toString() {
+ ", TLS: "
+ useTLS
+ ", SASL: "
+ useSASL
+ " : ";
+ useSASL;
}

@Override
Expand Down
Loading