Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing comma from hooks.json and fix SyntaxWarning in Python 3.12 #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

regunakyle
Copy link

This pull request does 2 things:

  1. Update the json_minify function in hooks to match the upstream version. One benefit is that it fixes SyntaxWarning that shows up in Python 3.12. I have tested it using my own hooks.json and can confirm that both version produce the same output
  2. Remove the trailing comma in hooks.json. The previous pull request left the comma there, and the json_minify function can't deal with it, so it crashes the hook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant