Add support for CSS round() with one unitless argument
#2436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also adds deprecation warnings for cases where a CSS calculation is determined to need to mimic a global Sass function, to match the global Sass function deprecation. See sass/sass#3803 Closes #2433
3 tasks
| Deprecation.globalBuiltin); | ||
| compatible = true; | ||
| } | ||
| if (compatible) { |
There was a problem hiding this comment.
Isn't it better to just make compatible a const and return
return operator == CalculationOperator.plus
? left.plus(right)
: left.minus(right);
either way? Since compatible is set to true if it's false.
There was a problem hiding this comment.
compatible is only set to true if inLegacySassFunction != null && left.isComparableTo(right).
pamelalozano16
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds deprecation warnings for cases where a CSS calculation
is determined to need to mimic a global Sass function, to match the
global Sass function deprecation.
See sass/sass#3803
Closes #2433
See sass/sass-spec#2037