Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC Blogpost for indented syntax #1260

Merged
merged 9 commits into from
Dec 3, 2024
Merged

Conversation

jamesnw
Copy link
Contributor

@jamesnw jamesnw commented Nov 26, 2024

No description provided.

Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for sass-lang ready!

Name Link
🔨 Latest commit ad4a871
🔍 Latest deploy log https://app.netlify.com/sites/sass-lang/deploys/674f454ee945bb000702115f
😎 Deploy Preview https://deploy-preview-1260--sass-lang.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@jgerigmeyer jgerigmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

source/blog/044-rfc-indented-syntax.md Outdated Show resolved Hide resolved
source/blog/044-rfc-indented-syntax.md Outdated Show resolved Hide resolved
source/blog/044-rfc-indented-syntax.md Outdated Show resolved Hide resolved
source/blog/044-rfc-indented-syntax.md Outdated Show resolved Hide resolved
@jamesnw
Copy link
Contributor Author

jamesnw commented Nov 27, 2024

@nex3 This is ready for review. It currently has today's date (11-27) but given the holiday, I could update that to next week if you'd prefer.

Comment on lines 19 to 20
Instead of adding syntax that is completely new to Sass, we propose to borrow
syntax from the SCSS format and make it available in the indented syntax. This
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think framing line-continuations as "from SCSS" is a bit misleading here, since the specific details of when line breaks are or are not allowed isn't particularly specific to SCSS at all.

source/blog/044-rfc-indented-syntax.md Outdated Show resolved Hide resolved
source/blog/044-rfc-indented-syntax.md Outdated Show resolved Hide resolved
source/blog/044-rfc-indented-syntax.md Outdated Show resolved Hide resolved
source/blog/044-rfc-indented-syntax.md Outdated Show resolved Hide resolved
source/blog/044-rfc-indented-syntax.md Outdated Show resolved Hide resolved
source/blog/044-rfc-indented-syntax.md Outdated Show resolved Hide resolved
source/blog/044-rfc-indented-syntax.md Outdated Show resolved Hide resolved
source/blog/044-rfc-indented-syntax.md Outdated Show resolved Hide resolved
@jamesnw jamesnw requested a review from nex3 December 3, 2024 02:20
@nex3 nex3 merged commit 4188409 into sass:main Dec 3, 2024
9 checks passed
@jgerigmeyer jgerigmeyer deleted the rfc-indented-syntax branch December 3, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants