feat: (IAC-1228) Support Azure Application Gateway with Azure WAF #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarpat
approved these changes
Nov 30, 2023
sayeun
approved these changes
Nov 30, 2023
dhoucgitter
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
New feature to support Azure Application Gateway with Azure WAF.
viya4-iac-azurerepo added new terraform azurerm resources to support this feature. For more details seeviya4-iac-azurePR #355.Note: There are related changes in the
viya4-iac-azurerepo to support these changes.Also note, the work in SAS Viya products is still in progress so there might be more changes coming in this feature but this change should help the initial testing effort.
Tests:
Verified following scenarios, see internal ticket for details.
create_app_gateway = true,V4_CFG_APPLICATION_GATEWAY_ENABLED: trueINGRESS_NGINX_AZURE_DNS_LABEL_NAME: "rp276t00a-ingress-nginx"create_app_gateway = true,INGRESS_NGINX_AZURE_DNS_LABEL_NAME: "rp276t00a-ingress-nginx"create_app_gateway = true,V4_CFG_APPLICATION_GATEWAY_ENABLEDandINGRESS_NGINX_AZURE_DNS_LABEL_NAMEnot set