feat: (IAC-1375) Edit Ingress Definitions for Alertmanager To Adapt Changes From Viya Monitoring #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riragh
approved these changes
Mar 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Update the
Prometheus.prometheusSpec.alertingEndpointsstanza in theuser-values-prom-operator.yamlfile for both our host-based and path-based templates. SAS Viya Monitoring has in an upcoming release that will be a breaking change for some users, the changes in the PR will be compatible with both the current configuration and the coming changes and prevent users from being impacted.For additional details on the change from
viya4-monitoring-kubernetessee the announcement underneath the notes for Version 1.2.22 (13FEB2024). The release of their change is tentatively scheduled the 1.2.23 release (expected mid-March).Tests
Prometheus.prometheusSpec.alertingEndpointsstanzaPrometheus.prometheusSpec.alertingEndpointsstanza