Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: (IAC-1009) Add support for network plugin mode overlay #360

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

riragh
Copy link
Member

@riragh riragh commented Jan 25, 2024

Changes:

This PR adds support to Azure CNI Overlay. New variable aks_network_plugin_mode is introduced in this change with possible value of "overlay". For more details see Azure CNI Overlay.

The codebase was updated to change the default value for aks_network_policy to null, as Azure CNI Overlay supports network policy options of "azure", "calico", or null.
This changes the previous default value for aks_network_policy, which would result in breaking change for existing users.

Test:

Verified following scenarios, see internal ticket for details:

Scenario Provider Task kubectl version order cadence
1 Azure aks_cluster_sku_tier = free, aks_network_plugin = "azure", aks_network_policy = "azure", aks_network_plugin_mode = "overlay" 1.27.9 ****** stable:2023.12
2 Azure aks_cluster_sku_tier = Standard, aks_network_plugin = "azure", aks_network_policy = "azure", aks_network_plugin_mode = "overlay" 1.27.9 ****** stable:2023.12
3 Azure aks_cluster_sku_tier = free, aks_network_plugin = "azure", aks_network_plugin_mode = "overlay" 1.27.9 ****** stable:2023.12
4 Azure aks_cluster_sku_tier = Standard, aks_network_plugin = "azure", aks_network_plugin_mode = "overlay" 1.27.9 ****** stable:2023.12
5 Azure aks_cluster_sku_tier = free, aks_network_plugin = "azure", aks_network_policy = "calico", aks_network_plugin_mode = "overlay" 1.27.9 ****** stable:2023.12
6 Azure aks_cluster_sku_tier = Standard, aks_network_plugin = "azure", aks_network_policy = "calico", aks_network_plugin_mode = "overlay" 1.27.9 ****** fast:2020

@riragh riragh added the enhancement New feature or request label Jan 25, 2024
@riragh riragh self-assigned this Jan 25, 2024
@riragh riragh linked an issue Jan 25, 2024 that may be closed by this pull request
Copy link
Member

@thpang thpang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@sayeun sayeun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@riragh riragh merged commit 87a00f5 into staging Jan 25, 2024
3 checks passed
@riragh riragh mentioned this pull request Feb 14, 2024
@riragh riragh deleted the IAC-1009 branch February 15, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: (IAC-1009) Support CNI Overlay
4 participants