Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add edit post feature #384

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Conversation

barnett617
Copy link
Contributor

This PR implements the feature "edit page" by referring to the implementation of Hugo PaperMod

close: #191

@satnaing
Copy link
Owner

satnaing commented Oct 2, 2024

Thanks for your PRs @barnett617
I'll look into them later since they have to be reviewed carefully.

@satnaing
Copy link
Owner

satnaing commented Oct 7, 2024

I think it will make more sense to display "Suggest Changes" inside post detail page.
What do you think? @barnett617
For that, we can do something like this since Datetime in post detail page will always be lg.

{size === "lg" && <EditPost editPost={editPost} postId={postId} />}

@barnett617
Copy link
Contributor Author

I think it will make more sense to display "Suggest Changes" inside post detail page. What do you think? @barnett617 For that, we can do something like this since Datetime in post detail page will always be lg.

{size === "lg" && <EditPost editPost={editPost} postId={postId} />}

It's up to you because it's relative to this blog theme layout style, i just implement this refers to Hugo PaperMod.
So it's okay to adjust it's display layout driven by your design.

@satnaing satnaing merged commit 0bc8eee into satnaing:main Oct 11, 2024
1 check passed
@satnaing
Copy link
Owner

I just updated what I mentioned, and updated the docs post.
Thanks for the PR.

@barnett617 barnett617 deleted the feature/editpage branch October 12, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit page
3 participants